eduwercamacaro commented on code in PR #21578:
URL: https://github.com/apache/kafka/pull/21578#discussion_r2896901640


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractColumnFamilyAccessor.java:
##########
@@ -54,8 +60,30 @@ public final void commit(final RocksDBStore.DBAccessor 
accessor, final Map<Topic
     }
 
     @Override
-    public void close() {
+    public void open(final RocksDBStore.DBAccessor accessor) throws 
RocksDBException {
+        final byte[] valueBytes = accessor.get(offsetColumnFamilyHandle, 
statusKey);
+        if (valueBytes == null || Arrays.equals(valueBytes, closedState)) {

Review Comment:
   Thanks for pointing that out.
   I think I'm addressing this [in this 
commit](https://github.com/apache/kafka/pull/21578/changes/31233bc91c01f9cc455241dd7808a9b6468cc3df).
   
   Let me know what you think about that.
   
   It basically passes a flag to the CF.open method to ignore the current state 
during initialization. So we set that flag to true when the processing mode is 
different than EOS. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to