dubeyKartikay opened a new pull request, #21679:
URL: https://github.com/apache/kafka/pull/21679
In this change, I had to remove the references of
kafka.utils.TestUtils.clearYammerMetrics (Scala version) from Java tests.
There was already a Java implementation written in
server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java,
so my job was made a lot easier.
Instead of directly importing this into all the affected modules, I
considered moving clearYammerMetrics to a more general class like
TestUtils.java.
But IMO, this function is too specific to be in TestUtils.java. So I made a
new YammerMetricsTestUtils class that could deal with all the util functions
for the Yammer related things.
In this PR, I have only changed the clearYammerMetrics.
I can see another Yammer-related function that could belong in
YammerMetricsTestUtils, namely yammerMetricValue. But that change should be
taken as a separate PR. All my opinion of course; I'm open to feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
