mjsax commented on code in PR #21674:
URL: https://github.com/apache/kafka/pull/21674#discussion_r2902754720
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -181,8 +181,11 @@ public void init(final StateStoreContext stateStoreContext,
false);
}
+ // This method must be public, to allow us to share code inside
AbstractSegments#openSegmentDB(...)
+ // We declare the same method on interface Segment.openDB(...) to make it
accessible
+ // and interface methods are `public`
@SuppressWarnings("unchecked")
- void openDB(final Map<String, Object> configs, final File stateDir) {
+ public void openDB(final Map<String, Object> configs, final File stateDir)
{
Review Comment:
This is the kinda undesired, but necessary side effect: we need to make this
`public` if we want to share more "segments code" -- let me know what you think
about this tradeoff.
It's not super clean TBH, as it does break encapsulation; if we think the
benefit is too small (to save a little bit of duplicated code), also very happy
to revert this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
