[ 
https://issues.apache.org/jira/browse/KAFKA-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064406#comment-18064406
 ] 

Young Joo Kim commented on KAFKA-20279:
---------------------------------------

Thanks, [~mjsax]  ! 

I've assigned it to myself and will start looking into the refactoring.:)

> Refactor `AbstractConfigurableStoreFactory#dslStoreFormat()`
> ------------------------------------------------------------
>
>                 Key: KAFKA-20279
>                 URL: https://issues.apache.org/jira/browse/KAFKA-20279
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Matthias J. Sax
>            Assignee: Young Joo Kim
>            Priority: Minor
>
> Atm, we track the configured DSL store format via `
> AbstractConfigurableStoreFactory#dslStoreFormat()` and sub-classe make 
> decision about how to translate the provided format, in particular what the 
> default is they are using if not set.
>  
> This works atm, but doesn't seem correct. The factory does not know, which 
> DSL operator (aka Processor implementation) uses it. We should make the 
> factory "dumb" and pull out this decision to the code that _uses_ the 
> factory, as only the creator of the factory has the context to make the right 
> decision.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to