dajac commented on code in PR #21700:
URL: https://github.com/apache/kafka/pull/21700#discussion_r2912714747
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupBuilder.java:
##########
@@ -39,7 +39,7 @@ public class ShareGroupBuilder {
public ShareGroupBuilder(String groupId, int groupEpoch) {
this.groupId = groupId;
this.groupEpoch = groupEpoch;
- this.assignmentEpoch = 0;
+ this.assignmentEpoch = 1;
this.assignmentTimestamp = 0L;
Review Comment:
ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupBuilder.java:
##########
@@ -40,7 +40,7 @@ public class ConsumerGroupBuilder {
public ConsumerGroupBuilder(String groupId, int groupEpoch) {
this.groupId = groupId;
this.groupEpoch = groupEpoch;
- this.assignmentEpoch = 0;
+ this.assignmentEpoch = 1;
this.assignmentTimestamp = 0L;
Review Comment:
Should we use `TargetAssignmentMetadata.INITIAL` to init those two?
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -22611,11 +22619,6 @@ public void
testConsumerGroupMemberJoinsWithRegexAndUpdatesItBeforeResolutionCom
List<CoordinatorRecord> expectedRecords = List.of(
// The member subscription is created.
GroupCoordinatorRecordHelpers.newConsumerGroupMemberSubscriptionRecord(groupId,
expectedMember1),
- // The group epoch is bumped.
- GroupCoordinatorRecordHelpers.newConsumerGroupEpochRecord(groupId,
1, 0),
- // The target assignment is created.
-
GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentRecord(groupId,
memberId1, Map.of()),
-
GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentMetadataRecord(groupId,
1, context.time.milliseconds()),
Review Comment:
Let's replace those with a comment explaining why there are not here.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupBuilder.java:
##########
@@ -42,7 +42,7 @@ public class StreamsGroupBuilder {
public StreamsGroupBuilder(String groupId, int groupEpoch) {
this.groupId = groupId;
this.groupEpoch = groupEpoch;
- this.targetAssignmentEpoch = 0;
+ this.targetAssignmentEpoch = 1;
this.targetAssignmentTimestamp = 0L;
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
