jsancio commented on code in PR #21122:
URL: https://github.com/apache/kafka/pull/21122#discussion_r2920416611
##########
server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java:
##########
@@ -20,27 +20,125 @@
import java.util.Map;
import java.util.Objects;
-public record FinalizedFeatures(
- MetadataVersion metadataVersion,
- Map<String, Short> finalizedFeatures,
- long finalizedFeaturesEpoch
-) {
- public static FinalizedFeatures fromKRaftVersion(MetadataVersion version) {
- return new FinalizedFeatures(version, Map.of(), -1);
- }
+/**
+ * Represents the finalized feature levels for a Kafka cluster.
+ * <p>
+ * This class can be in one of three states:
+ * <ul>
+ * <li>Unknown - metadata version is not yet known (use {@link
#unknown()})</li>
+ * <li>KRaft version only - only metadata version is known (use {@link
#fromKRaftVersion(MetadataVersion)})</li>
+ * <li>Full features - metadata version, features map, and epoch are all
known (use {@link #of(MetadataVersion, Map, long)})</li>
+ * </ul>
+ */
+public final class FinalizedFeatures {
+ private static final FinalizedFeatures UNKNOWN = new
FinalizedFeatures(null, Map.of(), -1);
- public FinalizedFeatures(
+ private final MetadataVersion metadataVersion;
+ private final Map<String, Short> finalizedFeatures;
+ private final long finalizedFeaturesEpoch;
+
+ private FinalizedFeatures(
MetadataVersion metadataVersion,
Map<String, Short> finalizedFeatures,
long finalizedFeaturesEpoch
) {
- this.metadataVersion = Objects.requireNonNull(metadataVersion);
+ this.metadataVersion = metadataVersion;
this.finalizedFeatures = new HashMap<>(finalizedFeatures);
this.finalizedFeaturesEpoch = finalizedFeaturesEpoch;
- this.finalizedFeatures.put(MetadataVersion.FEATURE_NAME,
metadataVersion.featureLevel());
+ if (metadataVersion != null) {
+ this.finalizedFeatures.put(MetadataVersion.FEATURE_NAME,
metadataVersion.featureLevel());
+ }
+ }
+
+ /**
+ * Returns a sentinel value representing unknown finalized features.
+ *
+ * @return the unknown finalized features instance
+ */
+ public static FinalizedFeatures unknown() {
+ return UNKNOWN;
+ }
+
+ /**
+ * Creates a new instance from the given KRaft metadata version.
+ *
+ * @param version the metadata version
+ * @return a new FinalizedFeatures instance
+ * @throws NullPointerException if version is null
+ */
+ public static FinalizedFeatures fromKRaftVersion(MetadataVersion version) {
+ Objects.requireNonNull(version, "version cannot be null");
+ return new FinalizedFeatures(version, Map.of(), -1);
+ }
+
+ /**
+ * Creates a new instance with the given metadata version, features map,
and epoch.
+ *
+ * @param metadataVersion the metadata version
+ * @param finalizedFeatures the map of feature names to their finalized
levels
+ * @param epoch the epoch of the finalized features
+ * @return a new FinalizedFeatures instance
+ * @throws NullPointerException if metadataVersion or finalizedFeatures is
null
+ */
+ public static FinalizedFeatures of(MetadataVersion metadataVersion,
Map<String, Short> finalizedFeatures, long epoch) {
+ Objects.requireNonNull(metadataVersion, "metadataVersion cannot be
null");
+ Objects.requireNonNull(finalizedFeatures, "finalizedFeatures cannot be
null");
+ return new FinalizedFeatures(metadataVersion, finalizedFeatures,
epoch);
+ }
+
+ /**
+ * Returns whether the metadata version is known.
+ *
+ * @return true if the metadata version is known, false otherwise
+ */
+ public boolean isMetadataKnown() {
+ return metadataVersion != null;
Review Comment:
Let's avoid using `null` please use `Optional<MetadataVersion>` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
