zheguang commented on code in PR #21706:
URL: https://github.com/apache/kafka/pull/21706#discussion_r2935068324
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AggregationWithHeadersDeserializer.java:
##########
@@ -44,7 +44,7 @@
* <p>
* This is used by KIP-1271 to deserialize aggregations with headers from
session state stores.
*/
-class AggregationWithHeadersDeserializer<AGG> implements
WrappingNullableDeserializer<AggregationWithHeaders<AGG>, Void, AGG> {
+public class AggregationWithHeadersDeserializer<AGG> implements
WrappingNullableDeserializer<AggregationWithHeaders<AGG>, Void, AGG> {
Review Comment:
That's right. It's a bit awkward to broaden this deserializer's scope, tbh.
One option is to move those benchmarked methods out of this deserializer, into
`Utils`, and instead only broaden the scope of `Utils`... Would this be
preferred? Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
