mjsax commented on code in PR #21725:
URL: https://github.com/apache/kafka/pull/21725#discussion_r2936446082


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -558,6 +559,7 @@ private static MainConsumerSetup setupMainConsumer(final 
TopologyMetadata topolo
                     processId,
                     config,
                     
parseHostInfo(config.getString(StreamsConfig.APPLICATION_SERVER_CONFIG)),
+                    parseRackId((String) 
config.originals().get(CommonClientConfigs.CLIENT_RACK_CONFIG)),

Review Comment:
   Yes. `CLIENT_RACK_CONFIG` is not a `StreamsConfig`, but it's defined in 
`CommonClientConfigs`, and thus 
`config.getString(CommonClientConfigs.CLIENT_RACK_CONFIG)` does not find it 
(and would just return `null`), so we need to fall back to `originals()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to