zheguang commented on code in PR #21706:
URL: https://github.com/apache/kafka/pull/21706#discussion_r2937701920
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AggregationWithHeadersDeserializer.java:
##########
@@ -44,7 +44,7 @@
* <p>
* This is used by KIP-1271 to deserialize aggregations with headers from
session state stores.
*/
-class AggregationWithHeadersDeserializer<AGG> implements
WrappingNullableDeserializer<AggregationWithHeaders<AGG>, Void, AGG> {
+public class AggregationWithHeadersDeserializer<AGG> implements
WrappingNullableDeserializer<AggregationWithHeaders<AGG>, Void, AGG> {
Review Comment:
:thinking: I'd only concern about reproducibility... On the other hand I'm
also not fond of the JMH-dependent scope hacks.
How about we just keep a reference in the commit message about the JMH
benchmarks within this PR? Then we could remove the JMH benchmarks in the
final commit...
Would this be preferable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
