[ https://issues.apache.org/jira/browse/KAFKA-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807039#comment-16807039 ]
Rajini Sivaram commented on KAFKA-7588: --------------------------------------- [~mimaison] Thank you, I was thinking it might not need a KIP if all we are doing is passing some additional configs to configurables. However passing `originals()` to existing classes that currently take `values()` will be a breaking change (since types would change) and that would need a KIP. The simplest option would be to ensure we provide custom configs as well to all Configurables that currently just get `values()`. I think that could be done without a KIP, even though a KIP may be useful to discuss the options. > Rationalize configurations passed to pluggable APIs > --------------------------------------------------- > > Key: KAFKA-7588 > URL: https://issues.apache.org/jira/browse/KAFKA-7588 > Project: Kafka > Issue Type: Improvement > Reporter: Mickael Maison > Assignee: Mickael Maison > Priority: Major > > There are a lot of extensions points both on the client and server sides. > Most of these pluggable APIs are configurable but the configurations they > receive are not the same. > For example, Serializers, Deserializers, Partitioners, Assignors, > QuotaCallbacks are passed config.originals(). On the other hand LoginModules, > PrincipalBuilders and AuthenticationCallbackHandlers are passed > config.values(). > In practice, having access to originals() is nice as it allows to use custom > configurations by simply adding it to the client/server configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)