squah-confluent commented on PR #21770: URL: https://github.com/apache/kafka/pull/21770#issuecomment-4067426921
> Do we want to avoid concurrent 4/5? -- the scheduler can basically decide the metrics get updated not immediately, but later than the submitted tasks's completion time. But then the metrics doesn't reflect the true completion time anymore. That property isn't important to the users of the `CoordinatorBackgroundThreadPoolExecutor` class. It only impacts this `testMetrics` test. > If we want a strict metrics semantics, I wonder if we should go for overwriting submit() rather than execute() in CoordinatorBackgroundThreadPoolExecutor? 🤔 That is very annoying to do because there are 3 `submit()` overloads and 2 `invokeAll()` overloads that must be overridden. Alternatively, there is `RunnableFuture<T> newTaskFor(Runnable, T) / newTaskFor(Callable<T>)` in `AbstractExecutorService` that can be overridden but again it is 2 overloads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
