lucasbru commented on code in PR #21722:
URL: https://github.com/apache/kafka/pull/21722#discussion_r2940260428
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -309,6 +311,18 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
consumer_group_migration_policy = context.globals.get(arg_name)
self.consumer_group_migration_policy = consumer_group_migration_policy
+ # Set enable_assignment_batching based on context and arguments.
+ # If not specified, defaults to true.
+ if enable_assignment_batching is None:
+ arg_name = 'enable_assignment_batching'
+ if context.injected_args is not None:
+ enable_assignment_batching =
context.injected_args.get(arg_name)
+ if enable_assignment_batching is None:
+ enable_assignment_batching = context.globals.get(arg_name)
+ if enable_assignment_batching is None:
+ enable_assignment_batching = True
Review Comment:
Does this mean we will have assignment batching disabled by default
everywhere?
##########
tests/kafkatest/tests/streams/streams_smoke_test.py:
##########
@@ -50,8 +50,14 @@ def __init__(self, test_context):
@matrix(processing_guarantee=['exactly_once_v2', 'at_least_once'],
crash=[True, False],
metadata_quorum=[quorum.combined_kraft],
- group_protocol=["classic", "streams"])
- def test_streams(self, processing_guarantee, crash, metadata_quorum,
group_protocol):
+ group_protocol=["classic"],
+ enable_assignment_batching=[False])
+ @matrix(processing_guarantee=['exactly_once_v2', 'at_least_once'],
+ crash=[True, False],
+ metadata_quorum=[quorum.combined_kraft],
+ group_protocol=["streams"],
+ enable_assignment_batching=[False, True])
Review Comment:
Are you sure we want to add the tests for all parameter combinations? This
will add a lot of testing time, since some of these system tests take a while
to run. I'm not strictly against it, but it seems some combinations (EOS vs
ALOS here?) do not necessarily add useful coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
