nicktelford commented on code in PR #21739:
URL: https://github.com/apache/kafka/pull/21739#discussion_r2940694074
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java:
##########
@@ -175,83 +176,73 @@ public void before() {
@Test
public void shouldReadCheckpointOffsets() throws IOException {
- final Map<TopicPartition, Long> expected = writeCheckpoint();
+ writeCheckpoint();
Review Comment:
We have one in
[LegacyCheckpointingStateStore](https://github.com/apache/kafka/blob/d7fed9d02354323fa031f99b758276cef2093afa/streams/src/test/java/org/apache/kafka/streams/state/internals/LegacyCheckpointingStateStoreTest.java#L585).
[shouldCheckpointOffsets](https://github.com/apache/kafka/blob/31f68e309a3320d2cf2de1ee5b4c586ff9cc085a/streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java#L514)
then verifies that `GlobalStateManagerImpl` is correctly wrapping stores with
LCSS, because otherwise offsets wouldn't be checkpointed.
I guess we don't have a test that explicitly verifies that GSMI calls
`migrateLegacyOffsets`; would you like me to add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
