aliehsaeedii commented on code in PR #21580:
URL: https://github.com/apache/kafka/pull/21580#discussion_r2936949422
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java:
##########
@@ -192,9 +192,11 @@ private ValueAndTimestamp<VOut> transformValue(final K
key, final ValueAndTimest
new RecordHeaders()
));
- final ValueAndTimestamp<VOut> result = ValueAndTimestamp.make(
- valueTransformer.transform(key,
getValueOrNull(valueAndTimestamp)),
- valueAndTimestamp == null ? UNKNOWN :
valueAndTimestamp.timestamp());
+ final ValueTimestampHeaders<VOut> result =
ValueTimestampHeaders.make(
+ valueTransformer.transform(key,
getValueOrNull(valueTimestampHeaders)),
+ valueTimestampHeaders == null ? UNKNOWN :
valueTimestampHeaders.timestamp(),
+ valueTimestampHeaders == null ? null :
valueTimestampHeaders.headers()
Review Comment:
Let's agree on `headers()`.
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -368,7 +368,8 @@ public void registerStore(final StateStore store,
@Override
public StateStore store(final String name) {
if (stores.containsKey(name)) {
- return stores.get(name).stateStore;
+ final StateStore stateStore = stores.get(name).stateStore;
+ return stateStore;
Review Comment:
left over from debugging phase:(
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java:
##########
@@ -181,7 +181,8 @@ public <S extends StateStore> S getStateStore(final String
name) {
}
final StateStore store = stateManager.store(name);
- return (S) wrapWithReadWriteStore(store);
+ final StateStore wrappedStore = wrapWithReadWriteStore(store);
+ return (S) wrappedStore;
Review Comment:
left over from debugging phase:(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
