chia7712 commented on code in PR #21481:
URL: https://github.com/apache/kafka/pull/21481#discussion_r2941893252
##########
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##########
@@ -164,9 +165,9 @@ private static Properties
parseTopicConfigsToBeAdded(TopicCommandOptions opts) {
throw new IllegalArgumentException("requirement failed: Invalid
topic config: all configs to be added must be in the format \"key=val\".");
}
- Properties props = new Properties();
+ Map<String, String> props = new HashMap<>();
configsToBeAdded.stream()
Review Comment:
> duplicate keys.
That is an interesting issue. I think we should open a separate Jira ticket
to discuss whether we should throw an exception if users configure duplicate
items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
