eduwercamacaro commented on code in PR #21750:
URL: https://github.com/apache/kafka/pull/21750#discussion_r2942118568


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -396,6 +391,16 @@ private List<ColumnFamilyHandle> 
mergeColumnFamilyHandleLists(final List<ColumnF
         return columnFamilies;
     }
 
+    private void writePosition() {
+        validateStoreOpen();
+        try {
+            cfAccessor.commit(dbAccessor, position);
+        } catch (final RocksDBException e) {
+            // TODO: fatal error?
+            throw new RuntimeException(e);

Review Comment:
   Makes sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to