[
https://issues.apache.org/jira/browse/KAFKA-20323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dejan Stojadinović updated KAFKA-20323:
---------------------------------------
Summary: Refactor test method to enable Mockito version upgrade (was:
Refactor test method in order to enable Mockito version upgrade)
> Refactor test method to enable Mockito version upgrade
> ------------------------------------------------------
>
> Key: KAFKA-20323
> URL: https://issues.apache.org/jira/browse/KAFKA-20323
> Project: Kafka
> Issue Type: Task
> Reporter: Dejan Stojadinović
> Priority: Minor
> Labels: help-wanted, refactor, up-for-grabs
>
> *Prologue:*
> [https://github.com/apache/kafka/pull/21651#issuecomment-4062468636]
> {panel:title=Task:|borderStyle=dashed|borderColor=#cccccc|titleBGColor=#f7d6c1|bgColor=#ffffce}
> Refactor test method *_testRecordPruningTaskPeriodicityWithSomeFailures()_*
> in _*ShareCoordinatorServiceTest*_ java class in order to enable Mockito
> version upgrade.
> {panel}
> *Scenario:*
> * upgrade Mockito version via _gradle/dependencies.gradle_ from 5.20.0 to
> 5.21.0 (or to some more recent version)
> * execute _*./gradlew share-coordinator:test --tests
> ShareCoordinatorServiceTest*_
> * build fails:
> {code:java}
> Gradle Test Run :share-coordinator:test > Gradle Test Executor 2 >
> ShareCoordinatorServiceTest >
> testRecordPruningTaskPeriodicityWithSomeFailures() FAILED
> org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
> at
> app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> at
> app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> at
> app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
> at
> app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
> at
> app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
> at
> app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
> at
> app//org.apache.kafka.coordinator.share.ShareCoordinatorServiceTest.checkPruneMetric(ShareCoordinatorServiceTest.java:2292)
> at
> app//org.apache.kafka.coordinator.share.ShareCoordinatorServiceTest.testRecordPruningTaskPeriodicityWithSomeFailures(ShareCoordinatorServiceTest.java:1585)
> {code}
> *More details:*
> {code:java}
> dejan@dejan:~/kafka$ git log -2 --oneline
> 8426afcb6a (HEAD -> trunk, upstream/trunk, upstream/HEAD, origin/trunk,
> origin/HEAD) MINOR: Fix bug where dslStoreFormat is non-null and always set
> to HEADERS (#21777)
> ce8c5f8497 KAFKA-20303: Optimize deserializers and HeadersBytesStore (#21769)
> dejan@dejan:~/kafka$ git diff
> diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
> index b233702688..9603eae30e 100644
> --- a/gradle/dependencies.gradle
> +++ b/gradle/dependencies.gradle
> @@ -118,7 +118,7 @@ versions += [
> lz4: "1.10.2",
> mavenArtifact: "3.9.11",
> metrics: "2.2.0",
> - mockito: "5.20.0",
> + mockito: "5.21.0",
> opentelemetryProto: "1.3.2-alpha",
> protobuf: "3.25.5", // a dependency of opentelemetryProto
> pcollections: "4.0.2",
> dejan@dejan:~/kafka$ ./gradlew share-coordinator:test --tests
> ShareCoordinatorServiceTest -q
> Starting build with version 4.3.0-SNAPSHOT (commit id 8426afcb) using Gradle
> 9.2.1, Java 21 and Scala 2.13.18
> Build properties: ignoreFailures=false, maxParallelForks=8,
> maxScalacThreads=8, maxTestRetries=0
> OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader
> classes because bootstrap classpath has been appended
> org.apache.kafka.coordinator.share.ShareCoordinatorServiceTest.testRecordPruningTaskPeriodicityWithSomeFailures()
> failed, log available in
> /home/dejan/kafka/share-coordinator/build/reports/testOutput/org.apache.kafka.coordinator.share.ShareCoordinatorServiceTest.testRecordPruningTaskPeriodicityWithSomeFailures().test.stdout
> 38 tests completed, 1 failed
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':share-coordinator:test'.
> > There were failing tests. See the report at:
> > file:///home/dejan/kafka/share-coordinator/build/reports/tests/test/index.html
> BUILD FAILED in 8s
> dejan@dejan:~/kafka$
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
