rreddy-22 opened a new pull request, #21782: URL: https://github.com/apache/kafka/pull/21782
[KIP-1228](https://cwiki.apache.org/confluence/display/KAFKA/KIP-1228%3A+Add+Transaction+Version+to+WriteTxnMarkersRequest) added a WriteTxnMarkersRequest v2 with a TransactionVersion field. However, TransactionMarkerChannelManager creates its NetworkClient with discoverBrokerVersions=false, which disables API version negotiation with peer brokers. Without version discovery, the ApiVersions cache is never populated — apiVersions.get(nodeId) returns null in NetworkClient.doSend(), causing it to fall through to builder.latestAllowedVersion() which blindly uses the highest version the sending broker knows about rather than negotiating a mutually supported version. In this fix we enable discovery and also fix the system test that could've caught this issue earlier. The system test was run locally and I verified that it failed without the fix and passed with the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
