DL1231 commented on code in PR #21781:
URL: https://github.com/apache/kafka/pull/21781#discussion_r2944114140


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java:
##########
@@ -272,6 +272,72 @@ public void testFencingWhenStateIsStable() {
         verify(subscriptionState).assignFromSubscribed(Collections.emptySet());
     }
 
+    @Test
+    public void 
testTransitionToFencedMarksPendingRevocationBeforeSignalingPartitionsLost() {

Review Comment:
   Thanks for the patch! Overall the fix looks good to me. Just noticed there 
are a few tests failing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to