mjsax commented on code in PR #21769:
URL: https://github.com/apache/kafka/pull/21769#discussion_r2944304224
##########
streams/src/main/java/org/apache/kafka/streams/state/HeadersBytesStore.java:
##########
@@ -52,11 +51,10 @@ static byte[] convertToHeaderFormat(final byte[]
valueAndTimestamp) {
// headersSize = varint(0) = [0x00]
// headersBytes = [] (empty, 0 bytes)
// Result: [0x00][payload]
- return ByteBuffer
- .allocate(1 + valueAndTimestamp.length)
- .put((byte) 0x00)
- .put(valueAndTimestamp)
- .array();
+ final byte[] res = new byte[1 + valueAndTimestamp.length];
Review Comment:
`res` is terrible variable name -- can we update it to
`valueTimestampHeaders` in https://github.com/apache/kafka/pull/21706 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
