AndrewJSchofield commented on code in PR #21785:
URL: https://github.com/apache/kafka/pull/21785#discussion_r2945523468
##########
server-common/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQ.java:
##########
@@ -23,6 +23,13 @@
* The main interface to identify implementations of dead letter queues for
share groups.
*/
public interface ShareGroupDLQ {
+ Throwable STALE_BATCH = new Exception("Offset part of stale batch.");
Review Comment:
Will this create an unnecessary and pointless stack trace when the
constructor is called? Maybe you need to create a subclass of
Throwable/Exception which has a no-op implementation of `fillInStackTrace` to
avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
