sjhajharia commented on code in PR #21783:
URL: https://github.com/apache/kafka/pull/21783#discussion_r2946071596


##########
tests/kafkatest/sanity_checks/test_performance_services.py:
##########
@@ -33,8 +33,8 @@ def __init__(self, test_context):
 
     @cluster(num_nodes=6)
     @matrix(version=[str(LATEST_2_1)], metadata_quorum=quorum.all_kraft)
-    @matrix(version=[str(DEV_BRANCH)], metadata_quorum=quorum.all_kraft, 
use_share_groups=[True])
-    def test_version(self, version=str(LATEST_2_1), metadata_quorum=quorum.zk, 
use_share_groups=False):

Review Comment:
   Did we run the System Tests once to ensure we do not include any regressions 
especially here given that this is the only place where `use_share_groups` was 
false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to