chia7712 commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r2956324908


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -550,7 +550,14 @@ static KafkaAdminClient createInternal(
             MetricsContext metricsContext = new KafkaMetricsContext(JMX_PREFIX,
                 
config.originalsWithPrefix(CommonClientConfigs.METRICS_CONTEXT_PREFIX));
             metrics = new Metrics(metricConfig, reporters, time, 
metricsContext);
+
+            // Use the appropriate bootstrap configuration determined by 
AdminBootstrapAddresses

Review Comment:
   It seems `AdminBootstrapAddresses.fromConfig(config);`  will resolve the dns 
already, which is conflict with KIP-909



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to