chia7712 commented on code in PR #22214:
URL: https://github.com/apache/kafka/pull/22214#discussion_r3192220235
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -528,7 +529,11 @@ private CommitPartitionValidator
validateTransactionalOffsetCommit(
// facility. In this case, a so-called simple group is created
and the request
// is accepted.
group =
groupMetadataManager.getOrMaybeCreateClassicGroup(request.groupId(), true);
+ } else if
(TxnOffsetCommitRequest.supportsGroupIdNotFoundError((short)
context.requestVersion())) {
Review Comment:
Not sure why `requestVersion` uses `int` rather than `short`, as
`header.apiVersion()` actually returns a short
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
