JiayaoS commented on code in PR #22230:
URL: https://github.com/apache/kafka/pull/22230#discussion_r3200028173
##########
clients/src/main/java/org/apache/kafka/server/authorizer/AuthorizableRequestContext.java:
##########
@@ -49,15 +49,17 @@ public interface AuthorizableRequestContext {
InetAddress clientAddress();
/**
- * 16-bit API key of the request from the request header. See
- * https://kafka.apache.org/protocol#protocol_api_keys for request types.
+ * The 16-bit API key ({@code request_api_key}) from the request header.
See
+ * https://kafka.apache.org/42/design/protocol/#the-messages for request
types.
*/
- int requestType();
+ short requestType();
Review Comment:
> Is this a breaking change?
Yes. Changing the return type from int to short is both a binary and source
incompatible change. Third-party Authorizer implementations that override
requestType() or requestVersion() with int return type will fail to compile,
and already-compiled plugins will throw NoSuchMethodError at runtime.
I'll scope this PR down to Javadoc-only changes, fixing the outdated
documentation link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
