jiafu1115 commented on code in PR #20913:
URL: https://github.com/apache/kafka/pull/20913#discussion_r3200623637
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -399,6 +411,15 @@ public Boolean remoteLogCopyDisable() {
return remoteLogConfig.remoteLogCopyDisable;
}
+
+ public long remoteCopyLagMs() {
+ return remoteLogConfig.remoteCopyLagMs == MAX_REMOTE_COPY_LAG_MS ?
localRetentionMs() : remoteLogConfig.remoteCopyLagMs;
Review Comment:
@kamalcph here. I add validation check to make sure the delay lag will <=
effective local retention:
https://github.com/apache/kafka/pull/20913/changes#diff-019dd06900a2f4714d626ffb071466765413970462f36a86e8a37c0ef9c0afb9R591
So it seems that you agree for -1 to reach the max delay? right?
if we using -1 to reach the max delay. no matter how we adust the local
retention.
if we using positive value for delay in normal case. we must check to make
sure the setting is valid: delay lag will <= effective local retention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
