jiafu1115 commented on code in PR #20913:
URL: https://github.com/apache/kafka/pull/20913#discussion_r3201080327
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -138,6 +144,10 @@ public Optional<String> serverConfigName(String
configName) {
public static final boolean DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE_CONFIG =
false;
public static final long DEFAULT_LOCAL_RETENTION_BYTES = -2; // It
indicates the value to be derived from RetentionBytes
public static final long DEFAULT_LOCAL_RETENTION_MS = -2; // It indicates
the value to be derived from RetentionMs
+ public static final long DEFAULT_REMOTE_COPY_LAG_MS = -2; // It indicates
no delay check based on local retention ms
+ public static final long DEFAULT_REMOTE_COPY_LAG_BYTES = -2; // It
indicates no delay check based on local retention bytes
Review Comment:
@kamalcph your case remind me to update the document which should remind
user. if user using the size retention and time retention policy at the same
time and user are not allow to set **only one** lag delay which will break
retention policy. right? is there any better solution for it? add validation
for configuration? or some thing else? thanks for your reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
