mimaison commented on code in PR #21963: URL: https://github.com/apache/kafka/pull/21963#discussion_r3202402097
########## release/github.py: ########## @@ -0,0 +1,128 @@ +# Review Comment: Could we use https://github.com/PyGithub/PyGithub instead of having our own logic? ########## release/github.py: ########## @@ -0,0 +1,128 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +Auxiliary functions to interact with the GitHub REST API. + +Set the GITHUB_REPO environment variable to override the target repository +(e.g. "myuser/kafka" to test against a personal fork). + +Set GITHUB_DRY_RUN=true to print API calls without executing them. Review Comment: Can this be added to the README? ########## release/templates.py: ########## @@ -267,6 +268,27 @@ def rc_email_instructions(rc_email_text): """ +def github_token_instructions(): Review Comment: Should this be in the README? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
