lianetm commented on PR #22242: URL: https://github.com/apache/kafka/pull/22242#issuecomment-4408925121
Thanks for the PR @adikou! I will also take a look next week, but wonder if it would be helpful to split this PR into smaller one to make progress better? E.g, we could try smaller PRs for the new components/func introduced with the KIP at the lower level (without wiring them into the consumers): RebalanceConsumer/ConsumerRebalanceListener/RebalanceDelegate, their tests. Then maybe worth splitting the wiring into the Consumers (Classic and Async). Also can consider handling other components separately (e.g, MockConsumer). Up to you that have the code in hand, just suggesting for consideration in case it helps. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
