muralibasani commented on code in PR #22233:
URL: https://github.com/apache/kafka/pull/22233#discussion_r3213468932
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -139,6 +139,8 @@ public class ProducerConfig extends AbstractConfig {
+ " <li><code>acks=1</code> This
will mean the leader will write the record to its local log but will respond"
+ " without awaiting full
acknowledgement from all followers. In this case should the leader fail
immediately after"
+ " acknowledging the record but
before the followers have replicated it then the record will be lost."
+ + " Acknowledged records may also
be lost when leadership moves (e.g., reassignment, preferred-leader election,"
+ + " or controlled shutdown) before
they reach the high watermark."
Review Comment:
not every reader knows about high watermark model. can we be abit more
explicit ? something like below ?
```suggestion
+ " or controlled shutdown) if it
was acknowledged but not yet replicated to the new leader.."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
