muralibasani commented on code in PR #22247:
URL: https://github.com/apache/kafka/pull/22247#discussion_r3215240615
##########
metadata/src/test/java/org/apache/kafka/image/ScramImageTest.java:
##########
@@ -17,116 +17,31 @@
package org.apache.kafka.image;
-import org.apache.kafka.clients.admin.ScramMechanism;
-import org.apache.kafka.common.metadata.RemoveUserScramCredentialRecord;
-import org.apache.kafka.common.metadata.UserScramCredentialRecord;
import org.apache.kafka.image.writer.ImageWriterOptions;
import org.apache.kafka.image.writer.RecordListWriter;
import org.apache.kafka.metadata.RecordTestUtils;
-import org.apache.kafka.metadata.ScramCredentialData;
import org.apache.kafka.server.common.ApiMessageAndVersion;
import org.apache.kafka.server.common.MetadataVersion;
-import org.apache.kafka.server.util.MockRandom;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.Timeout;
-import java.util.ArrayList;
-import java.util.HashMap;
import java.util.List;
-import java.util.Map;
import java.util.Optional;
-import java.util.Random;
-import static org.apache.kafka.clients.admin.ScramMechanism.SCRAM_SHA_256;
-import static org.apache.kafka.clients.admin.ScramMechanism.SCRAM_SHA_512;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
@Timeout(value = 40)
public class ScramImageTest {
- public static final ScramImage IMAGE1;
+ public static final ScramImage IMAGE1 = ScramImageTestFixtures.IMAGE1;
Review Comment:
ScramImageTestFixtures is shared by MetadataImageTestFixtures(
MetadataImageTestFixtures is in testfixtures because
BrokerMetadataPublisherTest.scala from core references MetadataImageTest)
So it is a shared one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
