dajac opened a new pull request, #22250:
URL: https://github.com/apache/kafka/pull/22250
- Consolidate `testHandleOffsetCommitRequestTopicsAndPartitionsValidation`
and
`testHandleOffsetCommitRequestTopicsAndPartitionsValidationWithTopicIds`
into a single `@ParameterizedTest @ApiKeyVersionsSource(apiKey =
ApiKeys.OFFSET_COMMIT)`
method that covers every API version, mirroring the shape of
`testHandleTxnOffsetCommitRequestTopicsAndPartitionsValidation`.
- Drop the unnecessary version gating on `topicId`/`name` in the
source request data of `testHandleOffsetCommitRequest` and
`testHandleOffsetCommitRequestFutureFailed`. Both fields can be set
unconditionally; the wire schema filters at serialization time and
the builder accepts requests that have both fields populated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
