squah-confluent commented on code in PR #22249:
URL: https://github.com/apache/kafka/pull/22249#discussion_r3215653684
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -706,21 +689,11 @@ public CoordinatorResult<TxnOffsetCommitResponseData,
CoordinatorRecord> commitT
final long currentTimeMs = time.milliseconds();
request.topics().forEach(topic -> {
- final TxnOffsetCommitResponseTopic topicResponse = new
TxnOffsetCommitResponseTopic().setName(topic.name());
+ final TxnOffsetCommitResponseTopic topicResponse = new
TxnOffsetCommitResponseTopic()
+ .setName(topic.name())
+ .setTopicId(topic.topicId());
Review Comment:
inconsequential nit: these are the other way around in the offset commit
path. Otherwise they're identical minus `RetentionTimeMs` handling and mapping
STALE_MEMBER_EPOCH to ILLEGAL_GENERATION.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
