chia7712 commented on code in PR #22254:
URL: https://github.com/apache/kafka/pull/22254#discussion_r3222602846


##########
build.gradle:
##########
@@ -1139,8 +1139,8 @@ project(':core') {
     implementation libs.re2j
 
     testImplementation testFixtures(project(':clients'))
-    testImplementation project(':group-coordinator').sourceSets.test.output
-    testImplementation project(':share-coordinator').sourceSets.test.output
+    testImplementation testFixtures(project(':group-coordinator'))
+    testImplementation testFixtures(project(':share-coordinator'))

Review Comment:
   Currently, the core module relies on ShareCoordinatorTestConfig for its 
integration tests. Since these ITs will eventually be migrated to the server 
module, extracting the config into testFixtures is a forward-looking and solid 
design choice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to