chia7712 commented on code in PR #22257:
URL: https://github.com/apache/kafka/pull/22257#discussion_r3224358555
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##########
@@ -929,7 +929,7 @@ private
Optional<CoordinatorResult<InitializeShareGroupStateResponseData, Coordi
Optional<CoordinatorMetadataImage.TopicMetadata> topicMetadataOp =
metadataImage.topicMetadata(topicId);
if (topicMetadataOp.isEmpty() ||
topicMetadataOp.get().partitionCount() <= partitionId) {
- log.error("Topic/TopicPartition not found in metadata image.");
+ log.error("Topic or partition not found in metadata image when
initializing: {}:null-{}.", topicId, partitionId);
Review Comment:
Maybe we should try our best to resolve the topic name here?
```java
log.error("Topic or partition not found in metadata image when
initializing: {}:{}-{}.", topicId,
topicMetadataOp.map(CoordinatorMetadataImage.TopicMetadata::name).orElse("null"),
partitionId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
