bbejeck commented on code in PR #22142:
URL: https://github.com/apache/kafka/pull/22142#discussion_r3244570494
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##########
@@ -912,6 +912,35 @@ interface DBAccessor {
void flush(final ColumnFamilyHandle... columnFamilies) throws
RocksDBException;
void reset();
void close();
+
+ default ManagedKeyValueIterator<Bytes, byte[]> all(final
ColumnFamilyHandle cf, final String storeName, final boolean forward) {
+ final RocksIterator iter = newIterator(cf);
+ if (forward) {
+ iter.seekToFirst();
+ } else {
+ iter.seekToLast();
+ }
+ return new RocksDbIterator(storeName, iter, forward);
+ }
+
+ default ManagedKeyValueIterator<Bytes, byte[]> range(final
ColumnFamilyHandle cf, final String storeName,
+ final Bytes
from, final Bytes to,
+ final boolean
forward, final boolean toInclusive) {
+ return new RocksDBRangeIterator(storeName, newIterator(cf), from,
to, forward, toInclusive);
+ }
+
+ default ManagedKeyValueIterator<Bytes, byte[]> prefixScan(final
ColumnFamilyHandle cf, final String storeName,
+ final
Bytes prefix, final Bytes to) {
+ return new RocksDBRangeIterator(storeName, newIterator(cf),
prefix, to, true, false);
+ }
+
+ default void commitStagedWrites() throws RocksDBException {
+ // no-op for non-transactional accessors
Review Comment:
Let's leave it as is then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
