squah-confluent commented on code in PR #22288:
URL: https://github.com/apache/kafka/pull/22288#discussion_r3245335273
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -21726,6 +21728,8 @@ public void testStreamsGroupEvaluatedConfigs() {
"num.standby.replicas",
String.valueOf(GroupCoordinatorConfig.STREAMS_GROUP_MAX_STANDBY_REPLICAS_DEFAULT)
),
assignor.lastPassedAssignmentConfigs());
+
assertEquals(GroupCoordinatorConfig.STREAMS_GROUP_MIN_TASK_OFFSET_INTERVAL_MS_DEFAULT,
Review Comment:
nit: The other asserts have a comment before them
```suggestion
// Verify task offset interval is evaluated to min.
assertEquals(GroupCoordinatorConfig.STREAMS_GROUP_MIN_TASK_OFFSET_INTERVAL_MS_DEFAULT,
```
##########
tools/src/test/java/org/apache/kafka/tools/ConfigCommandIntegrationTest.java:
##########
@@ -420,11 +420,12 @@ public void testAlterStreamsGroupTaskOffsetInterval() {
assertEquals("Completed updating config for group group.", message);
// Verify the updated config
- command = Stream.concat(quorumArgs(), Stream.of(
- "--entity-type", "groups",
- "--describe"));
- message = captureStandardOut(run(command));
- assertTrue(message.contains("streams.task.offset.interval.ms=45000"));
+ TestUtils.waitForCondition(() -> {
+ final Stream<String> cmd = Stream.concat(quorumArgs(), Stream.of(
+ "--entity-type", "groups",
+ "--describe"));
+ return
captureStandardOut(run(cmd)).contains("streams.task.offset.interval.ms=45000");
+ }, "Expected streams.task.offset.interval.ms=45000 for group group");
Review Comment:
`testAlterStreamsGroupNumOfStandbyReplicas` and
`testAlterStreamsGroupNumWarmupReplicas` are missing this wait. Shall we add it
to the other two tests too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
