adikou commented on code in PR #22270:
URL: https://github.com/apache/kafka/pull/22270#discussion_r3248274969
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##########
@@ -89,31 +103,37 @@
* Here is pseudo-code for a callback implementation for saving offsets:
* <pre>
* {@code
- * public class SaveOffsetsOnRebalance implements ConsumerRebalanceListener {
- * private Consumer<?,?> consumer;
+ * consumer.subscribe(List.of("topic-1", "topic-2"));
+ * consumer.setConsumerRebalanceListener(new ConsumerRebalanceListener() {
+ * @Override
+ * public void onPartitionsRevoked(Collection<TopicPartition>
partitions) {}
Review Comment:
Yes, I'm on board with that. Would this need to trigger a new vote? Can I
amend the KIP and reply to the VOTE thread if anyone has an objection? I've
seen the latter done recently in the mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
