chia7712 commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3253942808
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1045,9 +1045,6 @@ private void handleShareAcknowledgeSuccess(Node
fetchTarget,
metadata.updatePartitionLeadership(partitionsWithUpdatedLeaderInfo,
leaderNodes);
}
- if (acknowledgeRequestState.isProcessed) {
Review Comment:
> 2. The metrics are being recorded at the end of the response handler, so
we would be missing to update the share-fetch-rate and share-fetch-total
metrics for responses with top level errors. This is the same pattern in
FetchManager as well where we are missing these responses with top level
errors. Not sure if this was intended or we should account for these as well.
[Lianet
Magrans](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=lianetm)
could you help take a look at the regular consumer/share-consumer and see what
we should do here?
Is this addressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
