muralibasani commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3254283799


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -1045,9 +1045,6 @@ private void handleShareAcknowledgeSuccess(Node 
fetchTarget,
                 
metadata.updatePartitionLeadership(partitionsWithUpdatedLeaderInfo, 
leaderNodes);
             }
 
-            if (acknowledgeRequestState.isProcessed) {

Review Comment:
   @chia7712 thank you for the review. 
   I pushed a commit to address this. I also commented in the ticket about this 
change, if that looks ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to