nileshkumar3 commented on code in PR #22291:
URL: https://github.com/apache/kafka/pull/22291#discussion_r3254744124
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##########
@@ -1034,6 +1036,7 @@ public void testConnectorMetricsNewAndLegacy() throws
InterruptedException, Exec
}
private void testConnectorMetrics(String format, Supplier<Boolean>
assertions) throws InterruptedException, ExecutionException {
+ CollectAllMetricsReporter.METRICS.clear();
Review Comment:
You're right, it is redundant. @AfterEach clears METRICS after every test,
so by the time testConnectorMetrics runs the map is already empty. Removed the
clear from testConnectorMetrics and kept only the @AfterEach one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
