muralibasani commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3255300902
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -155,6 +155,8 @@ protected void handleFetchSuccess(final Node fetchTarget,
final FetchResponse response = (FetchResponse) resp.responseBody();
final FetchSessionHandler handler =
sessionHandler(fetchTarget.id());
+ metricsManager.recordLatency(resp.destination(),
resp.requestLatencyMs());
Review Comment:
moving it to finally will record the metric even if above lines 155 or 156
fail (while getting response and handler), and we don't want that right., same
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
