muralibasani commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3255300216
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -817,6 +817,8 @@ private void handleShareFetchSuccess(Node fetchTarget,
final ShareFetchResponse response = (ShareFetchResponse)
resp.responseBody();
final ShareSessionHandler handler =
sessionHandler(fetchTarget.id());
+ metricsManager.recordLatency(resp.destination(),
resp.requestLatencyMs());
Review Comment:
moving it to finally will record the metric even if above lines 817 or 818
fail (while getting response and handler), and we don't want that right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
