nileshkumar3 commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3255565253
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -817,6 +817,8 @@ private void handleShareFetchSuccess(Node fetchTarget,
final ShareFetchResponse response = (ShareFetchResponse)
resp.responseBody();
final ShareSessionHandler handler =
sessionHandler(fetchTarget.id());
+ metricsManager.recordLatency(resp.destination(),
resp.requestLatencyMs());
Review Comment:
Given the JIRA intent of capturing top-level errors too, IMO finally is a
cleaner fit. Curious what @chia7712/ @apoorvmittal10 think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
