apoorvmittal10 commented on PR #22129: URL: https://github.com/apache/kafka/pull/22129#issuecomment-4477588103
Thanks for the PR @adikou. Have you considered using metric.metricName() for logging, I can see the usage of same in Kafka code base for logging? I also do not currently see where we log KafkaMetric hence don't see the need of this change. However the change is minimal, I am happy to review further if you put this in a PR where you actually have a valid usage of same or can find incorrect logs printed through Kafka currently. Please let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
