FrankYang0529 commented on code in PR #22306:
URL: https://github.com/apache/kafka/pull/22306#discussion_r3266559428
##########
storage/src/test/java/org/apache/kafka/tiered/storage/integration/AlterLogDirTest.java:
##########
@@ -16,24 +16,51 @@
*/
package org.apache.kafka.tiered.storage.integration;
+import org.apache.kafka.clients.consumer.ConsumerConfig;
+import org.apache.kafka.clients.consumer.GroupProtocol;
+import org.apache.kafka.common.test.ClusterInstance;
+import org.apache.kafka.common.test.api.ClusterConfig;
+import org.apache.kafka.common.test.api.ClusterTemplate;
+import org.apache.kafka.common.test.api.Type;
+import org.apache.kafka.tiered.storage.TieredStorageTestAction;
import org.apache.kafka.tiered.storage.TieredStorageTestBuilder;
-import org.apache.kafka.tiered.storage.TieredStorageTestHarness;
+import org.apache.kafka.tiered.storage.TieredStorageTestContext;
import org.apache.kafka.tiered.storage.specs.KeyValueSpec;
import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.Set;
import static org.apache.kafka.common.utils.Utils.mkEntry;
import static org.apache.kafka.common.utils.Utils.mkMap;
+import static
org.apache.kafka.tiered.storage.utils.TieredStorageTestUtils.createServerPropsForRemoteStorage;
-public final class AlterLogDirTest extends TieredStorageTestHarness {
+public final class AlterLogDirTest {
- @Override
- public int brokerCount() {
- return 2;
+ private static final String TEST_CLASS_NAME = "alterlogdirtest";
+ private static final int BROKER_COUNT = 3;
+
+ private static List<ClusterConfig> clusterConfig() {
+ return List.of(ClusterConfig.defaultBuilder()
+ .setTypes(Set.of(Type.KRAFT))
+ .setBrokers(BROKER_COUNT)
+ .setDisksPerBroker(2)
+
.setServerProperties(createServerPropsForRemoteStorage(TEST_CLASS_NAME,
BROKER_COUNT, 5))
Review Comment:
How about `AlterLogDirTest.class.getSimpleName().toLowerCase(Locale.ROOT)`?
This follows pattern in TieredStorageTestHarness.
https://github.com/apache/kafka/blob/98ed67e73e6a13ca465f49d1c83144503ba4dd18/storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestHarness.java#L104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
