kevin-wu24 commented on PR #20707: URL: https://github.com/apache/kafka/pull/20707#issuecomment-4492113746
Hi @mannoopj, To me, the issue seems to be in step 4. In the current code, `KafkaClusterTestKit` formatting logic is using the `TestKitNodes.bootstrapMetadata` as the source of truth for feature levels, which does not mirror how the storage tool actually works. The storage tool takes the "defaults" from the supplied release-version, and then any manual feature overrides using `--feature=` take priority over that. I think a solution is that the `TestKitNodes` can have its `bootstrapMetadata`, but it should not be used within `KafkaClusterTestKit`. Instead, `TestKitNodes` should store `featureOverrides` and then the `KafkaClusterTestKit` formatting logic can match the logic of the storage tool. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
