nileshkumar3 commented on code in PR #22329:
URL: https://github.com/apache/kafka/pull/22329#discussion_r3270734781
##########
core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala:
##########
@@ -288,10 +287,15 @@ abstract class QuotaTestClients(topic: String,
}
private def verifyThrottleTimeMetric(quotaType: QuotaType, clientId: String,
expectThrottle: Boolean): Unit = {
- val throttleMetricValue = metricValue(throttleMetric(quotaType, clientId))
if (expectThrottle) {
- assertTrue(throttleMetricValue > 0, s"Client with id=$clientId should
have been throttled")
+ // Poll until at least one metric is recorded to give the broker thread
time to flush the throttled value
+ // after the response is snt
Review Comment:
Nit: typo in comment — snt → sent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
