lucasbru commented on code in PR #22245:
URL: https://github.com/apache/kafka/pull/22245#discussion_r3272903154
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -311,7 +313,7 @@ private static UpdateTargetAssignmentResult<TasksTuple>
fromLastTargetAssignment
if (member.isPresent()) {
return new UpdateTargetAssignmentResult<>(
group.assignmentEpoch(),
- group.targetAssignment(member.get().memberId())
+ group.targetAssignment(member.get().memberId(),
member.get().instanceId())
Review Comment:
member.get().memberId() is already in hand, so passing instanceId here
triggers a redundant staticMember lookup inside targetAssignment().
Optional.empty() would avoid it - this runs on every steady-state heartbeat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
