davide-armand commented on code in PR #18142:
URL: https://github.com/apache/kafka/pull/18142#discussion_r3287525601
##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageReaderImpl.java:
##########
@@ -86,14 +86,18 @@ public <T> Map<Map<String, T>, Map<String, Object>>
offsets(Collection<Map<Strin
Map<ByteBuffer, ByteBuffer> raw;
try {
Future<Map<ByteBuffer, ByteBuffer>> offsetReadFuture;
+
+ // Note: this call can block for long time waiting for data flush
to complete (`KafkaProducer.flush()`).
+ offsetReadFuture = backingStore.get(serializedToOriginal.keySet());
Review Comment:
@viktorsomogyi I forced pushed the suggested change, I agree it makes sense
to fail fast here.
I also pushed a separate commit to refactor
`OffsetStorageReaderImpl.offsets()` into smaller methods to fix a checkstyle
complexity error in the build caused by this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
